fix(workspace): harden runbook init with embed filter and service stubs (#325)#83
Open
advancedresearcharray wants to merge 3 commits into
Open
fix(workspace): harden runbook init with embed filter and service stubs (#325)#83advancedresearcharray wants to merge 3 commits into
advancedresearcharray wants to merge 3 commits into
Conversation
…bs (kiwifs#325) Wrap embedded templates with filteredTemplatesFS to exclude legacy runbook dirs that break kiwifs check, and add service stub pages for wiki links referenced by the example runbook frontmatter. Co-authored-by: Cursor <cursoragent@cursor.com>
…ifs#325) Hands-on takeover confirms embed filter and service stubs pass full test suite; records peer review pass for fleet publish. Co-authored-by: Cursor <cursoragent@cursor.com>
…wifs#325) Record green full-suite verification and peer review sign-off before opening PR for runbook init embed filter and service stub delivery. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filteredTemplatesFSto exclude legacy runbook dirs (incidents/,postmortems/,procedures/) and dev-only paths that breakkiwifs checkon generated workspacesservices/api-service.md,services/monitoring.md) so wiki links in the example runbook resolveCloses kiwifs#325
Test plan
go test ./internal/workspace/... ./cmd/... -run 'Runbook|runbook|Embed|embed|Filtered' -count=1go test ./... -count=1kiwifs init --template runbookscaffolds UC-6 workspace with all 7 sectionskiwifs checkexits 0 on generated scaffold (info-level janitor hints only)trigger,severity,owner,services)Made with Cursor